feat(session): allow session ID as direction in navigate_session_tree - #370
Merged
Merged
Conversation
When direction is not a known tree direction, treat it as a session ID and switch directly. Task action now passes metadata.sessionId so S key opens the exact child session.
Move session ID detection above tree-navigation active check so invalid inputs get clear feedback via empty_policy=notify. Update tests to match new behavior.
jensenojs
force-pushed
the
fix/task-direct-child-switch
branch
from
May 5, 2026 14:38
15b74c9 to
fad6fe5
Compare
sudo-tee
reviewed
May 6, 2026
sudo-tee
left a comment
sudo-tee
left a comment
Owner
There was a problem hiding this comment.
Looks good to me,
Only left 2 minor comments about removing obvious comments in the code
Owner
|
Thanks |
disrupted
pushed a commit
to disrupted/opencode-native.nvim
that referenced
this pull request
Jul 23, 2026
…sudo-tee#370) * feat(session): allow session ID as direction in navigate_session_tree When direction is not a known tree direction, treat it as a session ID and switch directly. Task action now passes metadata.sessionId so S key opens the exact child session. * fix(session): validate session ID path and update tests Move session ID detection above tree-navigation active check so invalid inputs get clear feedback via empty_policy=notify. Update tests to match new behavior. * remove unnessary comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When direction is not a known tree direction, treat it as a session ID and switch directly. Task action now passes metadata.sessionId so S key opens the exact child session.